In performance-sensitive hot paths, ensure you (1) don’t repeat expensive work, (2) keep async/event-loop paths non-blocking, (3) bound external operations with finite timeouts, and (4) avoid unnecessary computation/materialization by prefiltering queries and projecting only what’s needed.
Practical rules:
Example pattern (reused probe + bounded subprocess):
async def send_audio(path, upload_fn, send_msg_fn, ffprobe_fn):
# Probe once (prefer an async-friendly ffprobe wrapper if available)
duration_ms = await ffprobe_fn(path, timeout=10.0) # must be bounded
# Upload using the same duration metadata
media_id = await upload_fn(path, metadata={"duration_ms": duration_ms})
# Reuse for message payload (no second probe)
return await send_msg_fn(media_id, metadata={"duration_ms": duration_ms})
Checklist to apply during review:
Enter the URL of a public GitHub repository