Back to all reviewers

Intentional configuration management

better-auth/better-auth
Based on 2 comments
Json

Configuration choices should be intentional, balancing production requirements with developer experience while keeping configuration logic centralized in dedicated files rather than embedded inline.

Configurations Json

Reviewer Prompt

Configuration choices should be intentional, balancing production requirements with developer experience while keeping configuration logic centralized in dedicated files rather than embedded inline.

When making configuration decisions:

  • Move configuration logic from inline scripts to dedicated config files (e.g., biome.json, tsup.config.js)
  • Consider the impact on debugging and development workflows, not just production optimization
  • Separate development and production configurations when they serve different purposes

Example of moving from inline to centralized configuration:

// Instead of inline filters in package.json:
"format": "biome format . --write && pnpm --filter @better-auth/svelte-kit-example format"

// Define filters in biome.json and use simple commands:
"format": "biome format . --write"

For build configurations, provide separate commands for development and production needs:

{
  "scripts": {
    "build": "tsup --clean --dts",
    "build:prod": "tsup --clean --dts --minify"
  }
}

This approach ensures configurations are maintainable, discoverable, and support both development debugging and production requirements.

2
Comments Analyzed
Json
Primary Language
Configurations
Category

Source Discussions