Back to all reviewers

Consistent descriptive identifiers

oven-sh/bun
Based on 4 comments
TypeScript

Use camelCase for all variables, parameters, methods, and functions in JavaScript/TypeScript code to maintain consistency with language conventions. Choose names that accurately describe the purpose and behavior of identifiers, and avoid naming collisions between different scopes.

Naming Conventions TypeScript

Reviewer Prompt

Use camelCase for all variables, parameters, methods, and functions in JavaScript/TypeScript code to maintain consistency with language conventions. Choose names that accurately describe the purpose and behavior of identifiers, and avoid naming collisions between different scopes.

Do this:

interface CSVParserOptions {
  header?: boolean;
  delimiter?: string;
  trimWhitespace?: boolean; // camelCase instead of snake_case
  dynamicTyping?: boolean;  // camelCase instead of snake_case
}

function diagnose(
  fixtureDir: string,
  config: {
    options?: Partial<ts.CompilerOptions>;
    extraFiles?: Record<string, string>; // Clear, descriptive name that won't conflict
  } = {},
) {
  const tsconfig = config.options ?? {};
  const extraFiles = config.extraFiles;
  // ...
}

Don’t do this:

interface CSVParserOptions {
  header?: boolean;
  delimiter?: string;
  trim_whitespace?: boolean; // Inconsistent with JS/TS conventions
  dynamic_typing?: boolean;  // Inconsistent with JS/TS conventions
}

function diagnose(
  fixtureDir: string,
  config: {
    options?: Partial<ts.CompilerOptions>;
    files?: Record<string, string>; // Could conflict with local variables
  } = {},
) {
  const tsconfig = config.options ?? {};
  const files = config.files;
  // Can lead to confusion with other 'files' variables in the function
}

Avoid unused identifiers, or clearly document why they’re being parsed but not used. Choose names that accurately reflect the behavior of functions rather than their implementation details to improve code readability and maintainability.

4
Comments Analyzed
TypeScript
Primary Language
Naming Conventions
Category

Source Discussions