Back to all reviewers

Schema changes upstream first

docker/compose
Based on 3 comments
Json

When modifying configuration schemas, always propose changes to the upstream/source repository first before implementing them locally. This practice prevents schema divergence, maintains version integrity, and ensures a single source of truth for configuration definitions.

Configurations Json

Reviewer Prompt

When modifying configuration schemas, always propose changes to the upstream/source repository first before implementing them locally. This practice prevents schema divergence, maintains version integrity, and ensures a single source of truth for configuration definitions.

Key principles:

  • Never modify already released schema versions - use newer versions for new features
  • Submit changes to upstream repositories (like compose-spec) before local implementation
  • Reference upstream schemas as the authoritative source rather than maintaining local copies
  • Consolidate schema management to avoid inconsistencies across different versions

Example from the discussions:

// Instead of directly modifying local schema files
"secrets": {"$ref": "#/definitions/build_secrets"}

// First propose the change to upstream compose-spec repository
// Then reference the updated upstream schema

This approach ensures configuration schemas remain consistent across the ecosystem and prevents the fragmentation that occurs when teams make isolated changes to shared configuration standards.

3
Comments Analyzed
Json
Primary Language
Configurations
Category

Source Discussions