Back to all reviewers

Extract inline code

cypress-io/cypress
Based on 3 comments
TSX

Extract complex inline code elements into separate functions, components, or constants to improve readability and maintainability. This includes hardcoded strings, complex event handlers, and lengthy JSX expressions.

Code Style TSX

Reviewer Prompt

Extract complex inline code elements into separate functions, components, or constants to improve readability and maintainability. This includes hardcoded strings, complex event handlers, and lengthy JSX expressions.

Examples of what to extract:

  • Hardcoded strings: Move to constants or props instead of inline literals
  • Complex event handlers: Extract into separate functions rather than defining inline
  • Complex JSX expressions: Pull into separate components when they contain significant logic or styling
// Instead of inline handler:
onClick={(e) => {
  props.onClick(e, props.item)
  onClick(e, props.item)
}}

// Extract to function:
function handleClick(e) {
  props.onClick(e, props.item)
  if (props.item.onClick) {
    props.item.onClick(e, props.item)
  }
}

This practice makes code more testable, reusable, and easier to understand by giving meaningful names to code blocks and reducing visual complexity in the main component logic.

3
Comments Analyzed
TSX
Primary Language
Code Style
Category

Source Discussions