Back to all reviewers

Use semantically accurate names

electron/electron
Based on 3 comments
Markdown

Choose parameter and method names that accurately reflect their semantic meaning and implementation reality, rather than names that may be misleading or platform-specific.

Naming Conventions Markdown

Reviewer Prompt

Choose parameter and method names that accurately reflect their semantic meaning and implementation reality, rather than names that may be misleading or platform-specific.

Avoid names that imply specific technical requirements when the actual implementation is more flexible. For example, a parameter named guid suggests it must be a GUID format, when the implementation may accept any unique string identifier.

Similarly, method names should accurately describe their action. Names like evaluate can be misleading if they suggest using eval() when the actual implementation executes code differently.

Examples of improvements:

  • guid โ†’ identifier (when the parameter accepts any unique string, not just GUIDs)
  • roundedCorner โ†’ roundedCorners (when the property affects multiple corners)
  • evaluateInMainWorld โ†’ executeScriptInMainWorld (when the method executes rather than evaluates code)

This principle helps prevent developer confusion and makes APIs more intuitive across different platforms and use cases.

3
Comments Analyzed
Markdown
Primary Language
Naming Conventions
Category

Source Discussions