Back to all reviewers

Use benchmarked thresholds

golang/go
Based on 3 comments
Go

Base performance-critical constants, limits, and thresholds on empirical benchmarking rather than arbitrary values. When implementing optimizations that involve numeric parameters—such as buffer size limits, inlining costs, or caching thresholds—conduct systematic benchmarking to determine optimal values and document the rationale.

Performance Optimization Go

Reviewer Prompt

Base performance-critical constants, limits, and thresholds on empirical benchmarking rather than arbitrary values. When implementing optimizations that involve numeric parameters—such as buffer size limits, inlining costs, or caching thresholds—conduct systematic benchmarking to determine optimal values and document the rationale.

For memory management decisions, establish limits that balance performance gains with resource efficiency:

func cacheEncodeState(e *encodeState) {
    // Threshold determined through benchmarking to balance 
    // memory efficiency vs. performance gains
    if e.Buffer.Cap() > 32768 {
        return // Don't cache large buffers
    }
    // ... cache the state
}

const (
    // 57 was benchmarked to provide most benefit with no bad surprises
    inlineExtraCallCost = 57
    // These values were benchmarked to provide most benefit
    inlineBigForCost = 105
)

When creating benchmarks, separate different scenarios to get granular performance data rather than combining multiple cases. This enables more precise optimization decisions and helps identify the specific conditions where performance improvements matter most.

3
Comments Analyzed
Go
Primary Language
Performance Optimization
Category

Source Discussions