Back to all reviewers

Maintain clean code structure

hyprwm/Hyprland
Based on 8 comments
Other

Keep code well-organized by separating interface from implementation, managing dependencies properly, and following consistent structural patterns. Function bodies should remain in implementation files rather than headers to reduce compilation dependencies and improve maintainability. Organize includes strategically - move them to implementation files when...

Code Style Other

Reviewer Prompt

Keep code well-organized by separating interface from implementation, managing dependencies properly, and following consistent structural patterns. Function bodies should remain in implementation files rather than headers to reduce compilation dependencies and improve maintainability. Organize includes strategically - move them to implementation files when possible and always use relative paths rather than src-based paths. Structure classes and functions appropriately by preferring namespaces over global functions, placing functions within relevant classes when they operate on class data, and following standard member ordering with private members last. Avoid unnecessary code elements like redundant this usage.

Example of proper structure:

// Header file - interface only
class CHyprCtl {
public:
    static std::string getWindowData(PHLWINDOW w, eHyprCtlOutputFormat format);
private:
    // private members come last
    wl_event_source* m_eventSource = nullptr;
};

// Implementation file - bodies and includes
#include "relative/path/to/header.hpp"  // relative paths only
#include <fcntl.h>  // moved from global includes

std::string CHyprCtl::getWindowData(PHLWINDOW w, eHyprCtlOutputFormat format) {
    // implementation here, avoid unnecessary 'this->'
    return result;
}
8
Comments Analyzed
Other
Primary Language
Code Style
Category

Source Discussions