Back to all reviewers

maintain consistent naming patterns

istio/istio
Based on 3 comments
Yaml

Ensure naming consistency across related components and throughout the codebase to prevent developer confusion and maintenance issues. When similar concepts use different naming variations, choose one pattern and apply it consistently.

Naming Conventions Yaml

Reviewer Prompt

Ensure naming consistency across related components and throughout the codebase to prevent developer confusion and maintenance issues. When similar concepts use different naming variations, choose one pattern and apply it consistently.

Key principles:

  • Avoid similar but different names within the same context (e.g., “serve” vs “server”)
  • Prefer global consistency over local alignment when naming conflicts arise
  • Establish systematic patterns for recurring naming decisions (like Kubernetes labels)

Example from the codebase:

# Inconsistent - causes confusion
metadata:
  name: mtls-serve  # directory uses "serve"
spec:
  containers:
    - name: mtls-serve
      image: localhost:5000/mtls-server:latest  # image uses "server"

# Consistent - clear and predictable
metadata:
  name: mtls-server
spec:
  containers:
    - name: mtls-server
      image: localhost:5000/mtls-server:latest

When updating legacy naming, prioritize consistency with the broader system over maintaining alignment with individual objects. This reduces cognitive load and prevents the type of confusion that “is going to trip someone up one day.”

3
Comments Analyzed
Yaml
Primary Language
Naming Conventions
Category

Source Discussions