Back to all reviewers

Avoid external URLs

menloresearch/jan
Based on 1 comments
Markdown

Links to external repositories or domains in documentation and code can create security vulnerabilities through URL hijacking attacks. Malicious actors could potentially gain control of external domains and redirect users to harmful content or credential harvesting sites.

Security Markdown

Reviewer Prompt

Links to external repositories or domains in documentation and code can create security vulnerabilities through URL hijacking attacks. Malicious actors could potentially gain control of external domains and redirect users to harmful content or credential harvesting sites.

Always use official, internal, or trusted repository URLs instead of external ones. When linking to documentation, resources, or code examples, ensure the URLs point to your organization’s official repositories or well-established, trusted sources.

Example of the security risk:

<!-- Vulnerable - external repository -->
- <a href="https://github.com/NHPT/jan/blob/dev/README_CN.md">简体中文</a>

<!-- Secure - official repository -->
- <a href="https://github.com/janhq/jan/blob/dev/README_CN.md">简体中文</a>

This practice is especially critical in README files, documentation, and any user-facing content where links could be used to redirect users to potentially malicious sites.

1
Comments Analyzed
Markdown
Primary Language
Security
Category

Source Discussions