Simplify code structure

kubeflow/kubeflow

Based on 7 comments

Strive to simplify code structure by eliminating unnecessary complexity. This includes: 1. **Move conditions higher in the code** when appropriate to avoid unnecessary operations. Check conditions as early as possible to fail fast or skip work.

Code Style Go

Reviewer Prompt

Strive to simplify code structure by eliminating unnecessary complexity. This includes:

Move conditions higher in the code when appropriate to avoid unnecessary operations. Check conditions as early as possible to fail fast or skip work.

// Bad
if (someCondition) {
    // do work
}
if err := r.Update(ctx, profileIns); err != nil {
    return err
}

// Good
if (someCondition) {
    // do work
    if err := r.Update(ctx, profileIns); err != nil {
        return err
    }
}

Avoid unnecessary conditionals that don’t change program behavior.

// Bad
if !ok || existingValue != v {
    ns.Labels[k] = v
}

// Good
ns.Labels[k] = v

Simplify complex if statements by using early returns or continue statements to reduce nesting.

// Bad
if pod.Status.ContainerStatuses[i].Name == instance.Name && 
   pod.Status.ContainerStatuses[i].State != instance.Status.ContainerState {
    // handle condition
}

// Good
if pod.Status.ContainerStatuses[i].Name != instance.Name {
    continue
}
if pod.Status.ContainerStatuses[i].State == instance.Status.ContainerState {
    continue
}
// handle condition

Reduce nesting by checking negative conditions first and returning early.

// Bad
if nodename != "" {
    // lots of code here
}

// Good
if nodename == "" {
    return nil
}
// lots of code here with less indentation

Reuse existing functions instead of creating new ones with similar functionality.

This makes your code more readable, maintainable, and less error-prone.

Comments Analyzed

Primary Language

Code Style

Simplify code structure

Reviewer Prompt

Source Discussions

Add Repository

Private Repository