Back to all reviewers

Standardize build configurations

kubeflow/kubeflow
Based on 3 comments
Markdown

All components should use consistent build configurations and patterns in their CI/CD setup. This includes standardizing Makefile variables, build commands, and docker build processes across repositories. Inconsistent build configurations make CI/CD pipelines difficult to maintain and can lead to confusion during development.

CI/CD Markdown

Reviewer Prompt

All components should use consistent build configurations and patterns in their CI/CD setup. This includes standardizing Makefile variables, build commands, and docker build processes across repositories. Inconsistent build configurations make CI/CD pipelines difficult to maintain and can lead to confusion during development.

For example, use consistent variable naming across Makefiles:

# Use consistent variable names like REGISTRY_PROJECT
REGISTRY_PROJECT=my-repo make docker-build

Instead of having different variable names for the same concept in different components as noted in the discussion: “Tensorboard’s makefile uses slightly different vars but we should iron them out and have the same template”

This standardization simplifies CI/CD pipeline maintenance, improves developer experience when working across components, and ensures that all artifacts follow the same build and testing patterns. It also makes it clearer which components are part of the official CI/CD pipeline and which are provided as examples only.

3
Comments Analyzed
Markdown
Primary Language
CI/CD
Category

Source Discussions