Tests should be minimal and focused on the specific functionality being verified. Remove unnecessary passes, tools, or operations that aren't directly related to what's being tested to reduce noise and improve clarity.
Tests should be minimal and focused on the specific functionality being verified. Remove unnecessary passes, tools, or operations that aren’t directly related to what’s being tested to reduce noise and improve clarity.
Key principles:
llvm-as -disable-output
for verification tests instead of more complex alternatives)Example of improvement:
// Before: Includes unnecessary canonicalizer pass
// RUN: mlir-opt %s -convert-complex-to-rocdl -canonicalize | FileCheck %s
// After: Focuses only on the conversion being tested
// RUN: mlir-opt %s -convert-complex-to-rocdl | FileCheck %s
This approach makes tests easier to understand, maintain, and debug while ensuring they remain effective at catching regressions.
Enter the URL of a public GitHub repository