Back to all reviewers

Document design decisions

mui/material-ui
Based on 2 comments
TSX

When making architectural choices or modifying existing APIs, document your reasoning directly in the code or in type definitions. This helps other developers understand the "why" behind changes and prevents future regressions.

Documentation TSX

Reviewer Prompt

When making architectural choices or modifying existing APIs, document your reasoning directly in the code or in type definitions. This helps other developers understand the “why” behind changes and prevents future regressions.

For API changes:

// Document parameter changes in type definitions, even for internal components
interface GetTabbableProps {
  // Added third parameter to support focusing the first element
  container: HTMLElement;
  firstFocus: boolean;
  forceFirst?: boolean;
}

For architectural decisions:

// MuiMeta.tsx
// This component is separated from layout components to:
// 1. Minimize changes to core files
// 2. Isolate metadata logic for easier maintenance
// 3. Allow users to update metadata without modifying root structures
import theme from "./theme";

export default function MuiMeta() {
  // Metadata implementation
}

By documenting the reasoning behind your decisions, you make the codebase more maintainable and help other developers understand your design choices, reducing questions during code review and simplifying future updates.

2
Comments Analyzed
TSX
Primary Language
Documentation
Category

Source Discussions