Back to all reviewers

validate null undefined values

smallcloudai/refact
Based on 3 comments
TypeScript

Always perform explicit null and undefined checks before accessing object properties or using values in operations. Filter out undefined values from arrays and collections to prevent runtime errors and unexpected behavior.

Null Handling TypeScript

Reviewer Prompt

Always perform explicit null and undefined checks before accessing object properties or using values in operations. Filter out undefined values from arrays and collections to prevent runtime errors and unexpected behavior.

Key practices:

  • Keep null checks even when they seem redundant (typeof value === "object" && value !== null)
  • Use property existence checks before accessing nested properties ("tool_call_id" in msg)
  • Filter undefined values from arrays to maintain data integrity
  • Validate object properties exist before comparison operations

Example:

// Good: Explicit null check prevents runtime errors
if (typeof value === "object" && value !== null) {
  // Safe to access properties
}

// Good: Check property existence and filter undefined values
const toolMessages = tailMessages
  .filter(msg => "tool_call_id" in msg)
  .map(msg => msg.tool_call_id)
  .filter(id => id !== undefined);

// Good: Validate before property access
if (maybeLastAssistantMessageUsage) {
  const allMatch = Object.entries(currentUsage).every(
    ([key, value]) => maybeLastAssistantMessageUsage[key] === value
  );
}
3
Comments Analyzed
TypeScript
Primary Language
Null Handling
Category

Source Discussions