Back to all reviewers

Specify security requirements

microsoft/terminal
Based on 2 comments
Other

Always explicitly declare security requirements and provide clear security guidance in both configuration files and user-facing content. When operations require elevated privileges, specify the security context to ensure proper UAC prompting. When features have security implications, include explanatory text to help users make informed decisions.

Security Other

Reviewer Prompt

Always explicitly declare security requirements and provide clear security guidance in both configuration files and user-facing content. When operations require elevated privileges, specify the security context to ensure proper UAC prompting. When features have security implications, include explanatory text to help users make informed decisions.

For configuration files requiring elevation:

- resource: Microsoft.Windows.Developer/DeveloperMode
  directives:
    description: Enable Developer Mode
    allowPrerelease: true
    securityContext: elevated  # Required for UAC prompting

For user-facing security features, provide context about the security implications:

<data name="Globals_WarnAboutMultiLinePaste.HelpText" xml:space="preserve">
  <value>If your shell does not support "bracketed paste" mode, we recommend setting this to "Always" for security reasons.</value>
</data>

This practice ensures that security requirements are transparent to both the system (for proper privilege handling) and users (for informed decision-making), reducing the risk of security misconfigurations or unintended security bypasses.

2
Comments Analyzed
Other
Primary Language
Security
Category

Source Discussions