Back to all reviewers

Strategic configuration exclusions

tree-sitter/tree-sitter
Based on 2 comments
Swift

When configuring build exclusions in package manifests or configuration files, be strategic and minimal. Only exclude files that cause actual build issues (like non-source files that generate compilation warnings), while preserving important files such as licenses and directories that may be relevant for future features. Modern tooling often handles file...

Configurations Swift

Reviewer Prompt

When configuring build exclusions in package manifests or configuration files, be strategic and minimal. Only exclude files that cause actual build issues (like non-source files that generate compilation warnings), while preserving important files such as licenses and directories that may be relevant for future features. Modern tooling often handles file filtering automatically, so explicit exclusion lists may be unnecessary.

For example, in Package.swift:

.target(name: "TreeSitter",
        path: "lib",
        exclude: [
          // Only exclude files that cause build warnings
          "src/unicode/ICU_SHA",
          "src/unicode/README.md", 
          "src/unicode/LICENSE",
          // Don't exclude "src/wasm" - may be needed for future support
        ],

Before adding exclusions, verify they solve actual build problems rather than preemptively excluding files that might seem irrelevant. Consider whether newer versions of your build tools can handle the filtering automatically.

2
Comments Analyzed
Swift
Primary Language
Configurations
Category

Source Discussions