Back to all reviewers

Environment-specific configuration values

unionlabs/union
Based on 2 comments
Go

Avoid hardcoding configuration values that should vary between different deployment environments (testnet, mainnet, development). Instead, use environment variables, configuration files, or conditional logic to handle environment-specific settings.

Configurations Go

Reviewer Prompt

Avoid hardcoding configuration values that should vary between different deployment environments (testnet, mainnet, development). Instead, use environment variables, configuration files, or conditional logic to handle environment-specific settings.

Hardcoded values like network addresses, token supplies, or feature flags create deployment issues and require code changes for different environments. Use environment variables for optional features and implement proper branching logic for environment-specific constants.

Example of problematic hardcoded values:

const U_BASE_DENOM = "au"
const ONE_U = 1000000000000000000
const UNION_FOUNDATION_MULTI_SIG = "union1cpz5fhesgjcv2q0640uxtyur5ju65av6r8fem0"

Better approach using environment variables:

if depinjectOutPath, ok := os.LookupEnv("DEPINJECT_OUT_PATH"); ok {
    os.WriteFile(depinjectOutPath, []byte(dotGraph), 0644)
}

Consider implementing environment detection logic or configuration files to manage different settings for testnet versus mainnet deployments.

2
Comments Analyzed
Go
Primary Language
Configurations
Category

Source Discussions