Back to all reviewers

workspace dependency consistency

unionlabs/union
Based on 4 comments
Toml

All internal project dependencies should use workspace configuration instead of direct path or git references to ensure consistent versioning and build behavior across the monorepo. Maintain the standard `{ workspace = true }` syntax format and avoid redundant configuration options when using workspace dependencies.

Configurations Toml

Reviewer Prompt

All internal project dependencies should use workspace configuration instead of direct path or git references to ensure consistent versioning and build behavior across the monorepo. Maintain the standard { workspace = true } syntax format and avoid redundant configuration options when using workspace dependencies.

When adding new internal dependencies, always check if they can be configured in the workspace root and referenced consistently. Avoid specifying default-features = false or other options that may conflict with workspace-level configuration.

Example of correct workspace dependency usage:

[dependencies]
# Correct - uses workspace configuration
ibc-events = { workspace = true }
unionlabs = { workspace = true }

# Incorrect - direct path reference
# ibc-events = { version = "0.1.0", path = "../ibc-events" }

# Incorrect - direct git reference  
# sui_sdk = { git = "https://github.com/mystenlabs/sui", package = "sui-sdk" }

# Incorrect - redundant configuration with workspace
# unionlabs = { workspace = true, default-features = false }

This approach centralizes dependency management, reduces configuration drift, and ensures all modules use compatible versions of shared dependencies.

4
Comments Analyzed
Toml
Primary Language
Configurations
Category

Source Discussions