Awesome Reviewers checks + prompts

sources / apache/spark

apache/spark

The checks this repository runs, scanned at 13f1e87, and the review prompts derived from its discussions.

8 recognised tools
27 prompts
41554 stars
Databases & Data Platforms
GitHub

Static analysis

5 tools

ToolKindCommandRuns inFound in
eslint
configured, not run
Linting dev/package.json
mkdocs
configured, not run
Docs build pyproject.toml
mypy
configured, not run
Type checking pyproject.toml
python/mypy.ini
ruff-check
configured, not run
Linting pyproject.toml
sphinx
configured, not run
Docs build pyproject.toml

Testing

3 tools

ToolKindCommandRuns inFound in
hypothesis Property-based tests pyproject.toml
jest
configured, not run
Unit and integration tests ui-test/package.json
pytest
configured, not run
Unit and integration tests pyproject.toml
23 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • FROM docker.io/kubespark/spark:oidc-e2e-test
  • Rscript -e install.packages(c('knitr', 'rmarkdown', 'testthat', 'e1071', 'survival', 'arrow', 'xml2'), repos='https:/...
  • check docs $EXPR
  • check lint $EXPR
  • check pyspark-python-311 $EXPR
  • check pyspark-python-312 $EXPR
  • check pyspark-python-312-classic-only $EXPR
  • check pyspark-python-312-pandas-3 $EXPR
  • check pyspark-python-313 $EXPR
  • check pyspark-python-314 $EXPR
  • check pyspark-python-314-nogil $EXPR
  • check pyspark-python-315 $EXPR
  • check pyspark-python-minimum $EXPR
  • check sparkr $EXPR
  • elif [[ $MODULES_TO_TEST == *common#utils-java*
  • elif [[ $MODULES_TO_TEST == *sql#hive-thriftserver* ]]
  • elif [[ $MODULES_TO_TEST == *sql#pipelines*
  • elif [[ $MODULES_TO_TEST == connect
  • elif [[ $MODULES_TO_TEST == connect ]]
  • minikube mount ${PVC_TESTS_HOST_PATH}:${PVC_TESTS_VM_PATH} --gid=0 --uid=185 &
  • mvn -DskipTests -Psparkr -Djna.nosys=true package -Dmaven.version=3.8.7
  • node --experimental-vm-modules node_modules/jest/bin/jest.js
  • python ./dev/structured_logging_style.py

full scan as JSON

Review prompts

most discussed first

  • apache/spark Database Other data-systems
    raw open
  • apache/spark Code Style Other data-systems
    raw open
  • apache/spark Algorithms Other data-systems
    raw open
  • apache/spark Performance Optimization Other data-systems
    raw open
  • apache/spark API Other data-systems
    raw open
  • apache/spark Logging Other data-systems
    raw open
  • apache/spark Configurations Other data-systems
    raw open
  • apache/spark Configurations Python data-systems
    raw open
  • apache/spark Documentation Other data-systems
    raw open
  • apache/spark Null Handling Other data-systems
    raw open
  • apache/spark Error Handling Other data-systems
    raw open
  • apache/spark Database Java data-systems
    raw open
  • apache/spark Testing Sql data-systems
    raw open
  • apache/spark Configurations Xml data-systems
    raw open
  • apache/spark CI/CD Yaml data-systems
    raw open
  • apache/spark API Java data-systems
    raw open
  • apache/spark Code Style Java data-systems
    raw open
  • apache/spark Naming Conventions Java data-systems
    raw open
  • apache/spark Concurrency Other data-systems
    raw open
  • apache/spark Algorithms Python data-systems
    raw open
  • apache/spark Documentation Java data-systems
    raw open
  • apache/spark Testing Python data-systems
    raw open
  • apache/spark Null Handling Python data-systems
    raw open
  • apache/spark Configurations Java data-systems
    raw open
  • apache/spark Code Style Python data-systems
    raw open
  • apache/spark Null Handling Java data-systems
    raw open
  • apache/spark Algorithms Java data-systems
    raw open