Awesome Reviewers checks + prompts

sources / facebook/react-native

facebook/react-native

The checks this repository runs, scanned at edf2b86, and the review prompts derived from its discussions.

4 recognised tools
53 prompts
123178 stars
Application Frameworks & UI
GitHub

Static analysis

2 tools

ToolKindCommandRuns inFound in
eslint Linting eslint --max-warnings 0 . local package.json
.eslintrc.js
packages/rn-tester/.eslintrc
private/core-cli-utils/.eslintrc.json
tsc Type checking tsc -p packages/react-native/__typetests__/tsconfig.legacy.json
tsc -p packages/react-native/__typetests__/tsconfig.json
ci, local .github/workflows/test-all.yml
package.json

Testing

1 tool

ToolKindCommandRuns inFound in
jest Unit and integration tests jest --maxWorkers=2 --ci --reporters=default --reporters=jest-junit
jest
local package.json
jest.config.js
private/helloworld/jest.config.js
private/react-native-fantom/config/jest.config.js
ToolKindCommandRuns inFound in
prettier Formatting prettier --check ./**/*.{cjs,cts,flow,js,jsx,md,mjs,mts,ts,tsx,yaml,yml}
prettier --write ./**/*.{cjs,cts,flow,js,jsx,md,mjs,mts,ts,tsx,yaml,yml}
local package.json
.prettierrc.js
private/helloworld/.prettierrc.js
26 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • ecr verify-config
  • flow full-check
  • for formatter in javascript cpp kotlin java python swift
  • markdownlint-cli2 2>&1
  • node ./scripts/clang-format.js
  • node ./scripts/clang-format.js --check
  • node ./scripts/e2e/init-project-e2e.js --projectName RNTestProject --currentBranch $BRANCH --directory /tmp/RNTestPro...
  • node ./scripts/e2e/init-project-e2e.js --useHelloWorld --pathToLocalReactNative $GITHUB_WORKSPACE/build/$(cat build/r...
  • node ./scripts/e2e/init-project-e2e.js --useHelloWorld --pathToLocalReactNative /tmp/react-native-tmp/$(cat /tmp/reac...
  • node ./scripts/format-java.js
  • node ./scripts/format-java.js --check
  • node ./scripts/format-kotlin.js
  • node ./scripts/format-kotlin.js --check
  • node ./scripts/format-python.js
  • node ./scripts/format-python.js --check
  • node ./scripts/format-swift.js
  • node ./scripts/format-swift.js --check
  • node ./scripts/js-api/build-types
  • node ./scripts/release-testing/test-release-local-clean.js
  • node ./scripts/release-testing/test-release-local.js
  • node ./scripts/releases/set-rn-artifacts-version.js --build-type $EXPR
  • node .github/workflow-scripts/visual/approve-run.js prepare
  • node .github/workflow-scripts/visual/approve-run.js report
  • node scripts/ios-prebuild/headers-verify.js --flavor $EXPR ${{ inputs.version-type !=
  • tee .format-results/output.txt
  • xcodebuild -scheme RNTestProject -workspace RNTestProject.xcworkspace -configuration $EXPR -sdk iphonesimulator -dest...

full scan as JSON

Review prompts

most discussed first

  • facebook/react-native Concurrency Java app-frameworks
    raw open
  • facebook/react-native Code Style Kotlin app-frameworks
    raw open
  • facebook/react-native Null Handling Kotlin app-frameworks
    raw open
  • facebook/react-native Code Style JavaScript app-frameworks
    raw open
  • facebook/react-native Configurations JavaScript app-frameworks
    raw open
  • facebook/react-native Code Style Other app-frameworks
    raw open
  • facebook/react-native Naming Conventions Kotlin app-frameworks
    raw open
  • facebook/react-native Null Handling Other app-frameworks
    raw open
  • facebook/react-native Configurations Other app-frameworks
    raw open
  • facebook/react-native Performance Optimization JavaScript app-frameworks
    raw open
  • facebook/react-native Performance Optimization Other app-frameworks
    raw open
  • facebook/react-native API Other app-frameworks
    raw open
  • facebook/react-native Concurrency Other app-frameworks
    raw open
  • facebook/react-native Concurrency Kotlin app-frameworks
    raw open
  • facebook/react-native Naming Conventions JavaScript app-frameworks
    raw open
  • facebook/react-native React JavaScript app-frameworks
    raw open
  • facebook/react-native Configurations Json app-frameworks
    raw open
  • facebook/react-native Algorithms Other app-frameworks
    raw open
  • facebook/react-native Algorithms Java app-frameworks
    raw open
  • facebook/react-native Testing JavaScript app-frameworks
    raw open
  • facebook/react-native Null Handling Java app-frameworks
    raw open
  • facebook/react-native Error Handling Java app-frameworks
    raw open
  • facebook/react-native Configurations Kotlin app-frameworks
    raw open
  • facebook/react-native Performance Optimization Kotlin app-frameworks
    raw open
  • facebook/react-native Naming Conventions Other app-frameworks
    raw open
  • facebook/react-native Error Handling Kotlin app-frameworks
    raw open
  • facebook/react-native Null Handling JavaScript app-frameworks
    raw open
  • facebook/react-native Error Handling Other app-frameworks
    raw open
  • facebook/react-native Performance Optimization Java app-frameworks
    raw open
  • facebook/react-native Caching Kotlin app-frameworks
    raw open
  • facebook/react-native Algorithms JavaScript app-frameworks
    raw open
  • facebook/react-native Documentation JavaScript app-frameworks
    raw open
  • facebook/react-native API JavaScript app-frameworks
    raw open
  • facebook/react-native Configurations Ruby app-frameworks
    raw open
  • facebook/react-native Naming Conventions Ruby app-frameworks
    raw open
  • facebook/react-native Networking Java app-frameworks
    raw open
  • facebook/react-native Documentation Kotlin app-frameworks
    raw open
  • facebook/react-native Algorithms Objective-C app-frameworks
    raw open
  • facebook/react-native CI/CD JavaScript app-frameworks
    raw open
  • facebook/react-native Algorithms C++ app-frameworks
    raw open
  • raw open
  • facebook/react-native Logging JavaScript app-frameworks
    raw open
  • facebook/react-native Configurations Yaml app-frameworks
    raw open
  • facebook/react-native React Other app-frameworks
    raw open
  • facebook/react-native Configurations C++ app-frameworks
    raw open
  • facebook/react-native React Kotlin app-frameworks
    raw open
  • facebook/react-native Testing Kotlin app-frameworks
    raw open
  • facebook/react-native Code Style C++ app-frameworks
    raw open
  • facebook/react-native Configurations Java app-frameworks
    raw open
  • facebook/react-native React Java app-frameworks
    raw open
  • facebook/react-native Naming Conventions Java app-frameworks
    raw open
  • facebook/react-native Code Style Java app-frameworks
    raw open
  • facebook/react-native Security Other app-frameworks
    raw open