Awesome Reviewers checks + prompts

sources / llvm/llvm-project

llvm/llvm-project

The checks this repository runs, scanned at 030f8ab, and the review prompts derived from its discussions.

7 recognised tools
28 prompts
33702 stars
Language Runtimes & Compilers
GitHub

Static analysis

4 tools

ToolKindCommandRuns inFound in
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/gha-codeql.yml
pylint Linting pylint --disable=all --enable=E0102 $CHANGED_FILES ci .github/workflows/lldb-pylint-action.yml
zizmor CI workflow linting uses zizmorcore/zizmor-action ci .github/workflows/zizmor.yml
pyright
configured, not run
Type checking pyproject.toml

Testing

1 tool

ToolKindCommandRuns inFound in
pytest Unit and integration tests pytest ci .github/workflows/check-ci.yml
ToolKindCommandRuns inFound in
black
configured, not run
Formatting pyproject.toml
prettier
configured, not run
Formatting lldb/tools/lldb-dap/extension/.prettierrc.json
21 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi
  • abi-compliance-checker -lib $lib -old build-baseline/$lib*.abi -new build-latest/$lib*.abi
  • bash -c echo Running project checks targets: $WINDOWS_CHECK_TARGETS
  • bash -c echo Running runtimes checks targets: $WINDOWS_RUNTIMES_CHECK_TARGETS
  • bazelisk test --config=ci --sandbox_base= --remote_cache=https://storage.googleapis.com/$CACHE_GCS_BUCKET-bazel --goo...
  • cmake -GNinja -DCMAKE_BUILD_TYPE=Release ../llvm
  • cmake ../llvm -DCMAKE_BUILD_TYPE=Release -G Ninja
  • do echo Still checking out the test-suite...
  • do echo Still running the test-suite...
  • ninja check-hlsl-unit
  • ninja check-llvm-tools-dxil-dis
  • ninja split-file FileCheck
  • python ./.github/workflows/release-asset-audit.py $GITHUB_TOKEN
  • python ./llvm-project/llvm/utils/git/ids-check-helper.py --token $EXPR --issue-number $GITHUB_PR_NUMBER --idt-path $(...
  • python ./llvm/utils/git/code-format-helper.py --write-comment-to-file --token $EXPR --issue-number $GITHUB_PR_NUMBER ...
  • python llvm-test-suite/utils/lnt/run-test-suite.py ${LNT_MACHINE} --no-auto-name --succinct-compile-output --sandbox ...
  • python llvm/utils/git/code-lint-helper.py --token $EXPR --issue-number $GITHUB_PR_NUMBER --start-rev HEAD~1 --end-rev...
  • scan-build --generate-index-only build/analyzer-results
  • sha256sum --check
  • shasum --check -
  • test-suite diff from $BASE_SHA...$HEAD_SHA: $ARTIFACT_URL

full scan as JSON

Review prompts

most discussed first

  • llvm/llvm-project Code Style C++ runtimes
    raw open
  • llvm/llvm-project Naming Conventions C++ runtimes
    raw open
  • llvm/llvm-project Performance Optimization C++ runtimes
    raw open
  • llvm/llvm-project Testing C++ runtimes
    raw open
  • llvm/llvm-project Documentation C++ runtimes
    raw open
  • llvm/llvm-project Algorithms Other runtimes
    raw open
  • llvm/llvm-project Code Style Other runtimes
    raw open
  • llvm/llvm-project Naming Conventions Other runtimes
    raw open
  • llvm/llvm-project API C++ runtimes
    raw open
  • llvm/llvm-project Null Handling C++ runtimes
    raw open
  • llvm/llvm-project Error Handling C++ runtimes
    raw open
  • llvm/llvm-project Configurations C++ runtimes
    raw open
  • llvm/llvm-project Algorithms C++ runtimes
    raw open
  • llvm/llvm-project Testing Other runtimes
    raw open
  • llvm/llvm-project Configurations Other runtimes
    raw open
  • llvm/llvm-project Performance Optimization Other runtimes
    raw open
  • llvm/llvm-project Null Handling Other runtimes
    raw open
  • llvm/llvm-project API Other runtimes
    raw open
  • llvm/llvm-project Testing C runtimes
    raw open
  • llvm/llvm-project Networking Markdown runtimes
    raw open
  • llvm/llvm-project Logging Other runtimes
    raw open
  • llvm/llvm-project Documentation Markdown runtimes
    raw open
  • llvm/llvm-project Configurations C runtimes
    raw open
  • llvm/llvm-project Code Style Python runtimes
    raw open
  • llvm/llvm-project Concurrency C++ runtimes
    raw open
  • llvm/llvm-project Naming Conventions TypeScript runtimes
    raw open
  • llvm/llvm-project Documentation Other runtimes
    raw open
  • llvm/llvm-project Error Handling Other runtimes
    raw open