Awesome Reviewers checks + prompts

sources / maplibre/maplibre-native

maplibre/maplibre-native

The checks this repository runs, scanned at 208f8f0, and the review prompts derived from its discussions.

9 recognised tools
40 prompts
1411 stars
Application Frameworks & UI
GitHub

Static analysis

5 tools

ToolKindCommandRuns inFound in
actionlint CI workflow linting pre-commit hook actionlint pre-commit, ci .pre-commit-config.yaml
cargo-check Type checking cargo check --workspace --all-targets local rustutils/justfile
clippy Linting cargo clippy --all-targets --workspace -- -D warnings local rustutils/justfile
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/linux-ci.yml
.github/workflows/windows-ci.yml
tsc Type checking tsc -p tsconfig.json ci .github/workflows/validate-scripts.yml
package.json

Testing

2 tools

ToolKindCommandRuns inFound in
cargo-test Unit and integration tests cargo test --all-targets --workspace local rustutils/justfile
ci-matrix Version and platform matrix linux-build-and-test (variant: 3)
windows-build-and-test-msvc (renderer: 3)
windows-build-and-test-msys2 (msystem: 3, renderer: 3)
ci .github/workflows/linux-ci.yml
.github/workflows/windows-ci.yml
ToolKindCommandRuns inFound in
pre-commit-hooks File hygiene pre-commit hook check-added-large-files
pre-commit hook check-toml
pre-commit hook check-yaml
pre-commit, ci .pre-commit-config.yaml
rustfmt Formatting cargo fmt --all'
cargo fmt --all -- --check
cargo fmt --all -- --config imports_granularity=Module,group_imports=StdExter...
pre-commit, ci, local .pre-commit-config.yaml
rustutils/justfile
34 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • bazel run //platform/ios:lint-plists --//:renderer=metal
  • bazel test //platform/ios/test:ios_test --test_output=errors --//:renderer=metal
  • bazel test //platform:check-public-symbols-ios --test_output=errors --//:renderer=metal
  • bazel test //platform:check-public-symbols-macos --test_output=errors --//:renderer=metal
  • cargo doc --no-deps
  • cargo doc --no-deps --open
  • ditto $iphoneos_developer_dir/Library/Frameworks/Testing.framework Payload/CppUnitTestsApp.app/Frameworks/Testing.fra...
  • ditto $iphoneos_developer_dir/Library/Frameworks/Testing.framework Payload/RenderTestApp.app/Frameworks/Testing.frame...
  • ditto $iphoneos_developer_dir/usr/lib/lib_TestingInterop.dylib Payload/CppUnitTestsApp.app/Frameworks/lib_TestingInte...
  • ditto $iphoneos_developer_dir/usr/lib/lib_TestingInterop.dylib Payload/RenderTestApp.app/Frameworks/lib_TestingIntero...
  • ditto CppUnitTestsApp.app Payload/CppUnitTestsApp.app
  • ditto RenderTestApp.app Payload/RenderTestApp.app
  • else
  • node .github/scripts/check-job-skipped.ts
  • node platform/android/scripts/generate-style-code.mjs
  • node scripts/aws-device-farm/store-test-artifacts.mjs --runArn $EXPR --outputDir $results_dir
  • node test/storage/server.js &
  • pre-commit hook buildifier
  • pre-commit hook clang-format
  • pre-commit hook swiftformat
  • sh -c 'cd rustutils
  • unzip -o MapLibreAndroidTestApp/build/outputs/apk/$EXPR/release/MapLibreAndroidTestApp-$EXPR-release.apk -d /tmp/my_a...
  • unzip docs.zip
  • xcodebuild build-for-testing -scheme CppUnitTests -project MapLibre.xcodeproj -derivedDataPath $build_dir
  • xcodebuild build-for-testing -scheme RenderTest -project MapLibre.xcodeproj -derivedDataPath $build_dir
  • xvfb-run -a build-linux-$EXPR/mbgl-render-test-runner --manifestPath=metrics/linux-$renderer.json
  • xvfb-run -a build-linux-$EXPR/mbgl-test-runner
  • zip -r $ios_cpp_test_app_dir/CppUnitTests.xctest.zip CppUnitTests.xctest
  • zip -r $render_test_app_dir/RenderTest.xctest.zip RenderTest.xctest
  • zip -r CppUnitTestsApp.zip Payload
  • zip -r RenderTestApp.zip Payload
  • zip -r docs.zip docs/
  • zip -r test/android/app/src/main/assets/data.zip -@ < test/android/app/src/main/assets/to_zip.txt
  • zip -r test_artifacts.zip $results_dir

full scan as JSON

Review prompts

most discussed first

  • maplibre/maplibre-native Code Style Other app-frameworks
    raw open
  • maplibre/maplibre-native Error Handling Other app-frameworks
    raw open
  • maplibre/maplibre-native Code Style C++ app-frameworks
    raw open
  • maplibre/maplibre-native Error Handling C++ app-frameworks
    raw open
  • maplibre/maplibre-native API Markdown app-frameworks
    raw open
  • maplibre/maplibre-native Naming Conventions Other app-frameworks
    raw open
  • maplibre/maplibre-native Documentation Other app-frameworks
    raw open
  • maplibre/maplibre-native Documentation Markdown app-frameworks
    raw open
  • maplibre/maplibre-native Null Handling C++ app-frameworks
    raw open
  • maplibre/maplibre-native Logging C++ app-frameworks
    raw open
  • maplibre/maplibre-native Concurrency C++ app-frameworks
    raw open
  • maplibre/maplibre-native Configurations Markdown app-frameworks
    raw open
  • raw open
  • maplibre/maplibre-native Naming Conventions C++ app-frameworks
    raw open
  • maplibre/maplibre-native Performance Optimization C++ app-frameworks
    raw open
  • maplibre/maplibre-native Concurrency Kotlin app-frameworks
    raw open
  • maplibre/maplibre-native Configurations Other app-frameworks
    raw open
  • maplibre/maplibre-native CI/CD Other app-frameworks
    raw open
  • raw open
  • raw open
  • maplibre/maplibre-native Code Style Java app-frameworks
    raw open
  • maplibre/maplibre-native Null Handling Other app-frameworks
    raw open
  • maplibre/maplibre-native Configurations Kotlin app-frameworks
    raw open
  • maplibre/maplibre-native Performance Optimization Other app-frameworks
    raw open
  • maplibre/maplibre-native Configurations C++ app-frameworks
    raw open
  • maplibre/maplibre-native Algorithms Other app-frameworks
    raw open
  • maplibre/maplibre-native Testing C++ app-frameworks
    raw open
  • raw open
  • maplibre/maplibre-native Algorithms C++ app-frameworks
    raw open
  • maplibre/maplibre-native Configurations Shell app-frameworks
    raw open
  • maplibre/maplibre-native Configurations Yaml app-frameworks
    raw open
  • maplibre/maplibre-native Documentation Kotlin app-frameworks
    raw open
  • maplibre/maplibre-native Testing Json app-frameworks
    raw open
  • maplibre/maplibre-native Observability C++ app-frameworks
    raw open
  • maplibre/maplibre-native Concurrency Java app-frameworks
    raw open
  • maplibre/maplibre-native CI/CD Markdown app-frameworks
    raw open
  • maplibre/maplibre-native Code Style Markdown app-frameworks
    raw open
  • maplibre/maplibre-native Performance Optimization Yaml app-frameworks
    raw open
  • maplibre/maplibre-native Security Swift app-frameworks
    raw open
  • maplibre/maplibre-native Security C++ app-frameworks
    raw open