Awesome Reviewers checks + prompts

sources / nodejs/node

nodejs/node

The checks this repository runs, scanned at d36e9ba, and the review prompts derived from its discussions.

8 recognised tools
31 prompts
112178 stars
Language Runtimes & Compilers
GitHub

Static analysis

6 tools

ToolKindCommandRuns inFound in
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/codeql.yml
shellcheck Linting shellcheck -V ci .github/workflows/linters.yml
eslint
configured, not run
Linting deps/npm/node_modules/diff/eslint.config.mjs
deps/npm/node_modules/node-gyp/eslint.config.js
deps/undici/src/eslint.config.js
deps/v8/tools/clusterfuzz/js_fuzzer/.eslintrc.js
flake8
configured, not run
Linting deps/v8/.flake8
pyright
configured, not run
Type checking deps/v8/pyrightconfig.json
ruff-check
configured, not run
Linting pyproject.toml

Testing

2 tools

ToolKindCommandRuns inFound in
ci-matrix Version and platform matrix analyze (language: 3) ci .github/workflows/codeql.yml
unittest Unit and integration tests unittest discover -s ./test/tools local Makefile
72 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • CI_DOC := doctool
  • CI_DOC =
  • awwx
  • c8 report --check-coverage
  • else $(PYTHON) tools/test.py $(PARALLEL_ARGS) doctool
  • else $(RM) -r test/addons/??_*/
  • else $(RM) -r tools/doc/.manpagecheck
  • else echo >&2
  • else echo Running JS linter...
  • head -n1
  • http.server 8000 --bind 127.0.0.1 --directory out/doc/api
  • nix-store --realise ${NIX_LINTER%/bin/*}
  • node -p require("./test/fixtures/wpt/versions.json")[process.argv[1]].commit $SUBSYSTEM
  • node tools/actions/lint-release-proposal-commit-list.mjs $CHANGELOG_PATH $GITHUB_SHA
  • ps awwx
  • python ./configure --dest-cpu=$(ARCHTYPE) --tag=$(TAG) --release-urlbase=$(RELEASE_URLBASE) $(CONFIG_FLAGS) $(BUILD_R...
  • python deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) mjsunit cctest debugger inspector message...
  • python deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) benchmarks $(TAP_V8_BENCHMARKS)
  • python deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) intl $(TAP_V8_INTL)
  • python tools/checkimports.py $?
  • python tools/clang-format/node_modules/.bin/git-clang-format --binary=tools/clang-format/node_modules/.bin/clang-form...
  • python tools/cpplint.py $(CPPLINT_QUIET) $?
  • python tools/cpplint.py $(CPPLINT_QUIET) --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES_GLOB)
  • python tools/install.py install --headers-only --dest-dir $(ADDONS_HEADERS_DIR) --prefix /
  • python tools/perfetto/get_trace_processor.py $@
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER)
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) $(JS_SUITES) $(NATIVE_SUITES)
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) $(TEST_CI_ARGS) --skip-tests=$(CI_SKIP_TESTS) $(JS_SU...
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --valgrind sequential parallel message
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) addons
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) ffi
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) js-native-api
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) node-api
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) sqlite
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
  • python tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) v8-updates
  • python tools/test.py $(PARALLEL_ARGS) --mode=debug,release
  • python tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind
  • python tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap --mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS...

full scan as JSON

Review prompts

most discussed first

  • nodejs/node Error Handling Markdown runtimes
    raw open
  • nodejs/node API Markdown runtimes
    raw open
  • nodejs/node Error Handling JavaScript runtimes
    raw open
  • nodejs/node API Other runtimes
    raw open
  • nodejs/node Performance Optimization JavaScript runtimes
    raw open
  • nodejs/node API JavaScript runtimes
    raw open
  • nodejs/node Code Style JavaScript runtimes
    raw open
  • nodejs/node Naming Conventions Markdown runtimes
    raw open
  • nodejs/node Concurrency Other runtimes
    raw open
  • nodejs/node Null Handling Other runtimes
    raw open
  • nodejs/node Code Style Other runtimes
    raw open
  • nodejs/node Documentation JavaScript runtimes
    raw open
  • nodejs/node Error Handling Other runtimes
    raw open
  • nodejs/node Testing JavaScript runtimes
    raw open
  • nodejs/node Configurations Other runtimes
    raw open
  • nodejs/node Naming Conventions Other runtimes
    raw open
  • nodejs/node Configurations JavaScript runtimes
    raw open
  • nodejs/node Naming Conventions JavaScript runtimes
    raw open
  • nodejs/node Documentation Other runtimes
    raw open
  • nodejs/node Concurrency JavaScript runtimes
    raw open
  • nodejs/node Documentation Markdown runtimes
    raw open
  • nodejs/node Performance Optimization Markdown runtimes
    raw open
  • nodejs/node Null Handling JavaScript runtimes
    raw open
  • nodejs/node Observability Markdown runtimes
    raw open
  • nodejs/node Performance Optimization Other runtimes
    raw open
  • nodejs/node Configurations Shell runtimes
    raw open
  • nodejs/node Testing Other runtimes
    raw open
  • nodejs/node Security JavaScript runtimes
    raw open
  • nodejs/node Algorithms Other runtimes
    raw open
  • nodejs/node Security Other runtimes
    raw open
  • nodejs/node Security Markdown runtimes
    raw open