Awesome Reviewers checks + prompts

sources / temporalio/temporal

temporalio/temporal

The checks this repository runs, scanned at d167000, and the review prompts derived from its discussions.

3 recognised tools
23 prompts
14953 stars
Containers & Orchestration
GitHub

Static analysis

2 tools

ToolKindCommandRuns inFound in
go-vet Linting go vet -tags $(1) -vettool=$(ERRORTYPE) -style-check=false $(2) local Makefile
golangci-lint
configured, not run
Linting .github/.golangci.yml

Testing

1 tool

ToolKindCommandRuns inFound in
go-test Unit and integration tests go test -c -cover -o /dev/null $(COMPILED_TEST_ARGS) $(COVERPKG_FLAG) $(FUNCT...
go test -run TestClusterShutdownLeak -count=1 -v -timeout $(LEAK_TIMEOUT) $(T...
go test $(TEST_TAG_FLAG) -exec=true -count=0 $(TEST_DIRS)
ci, local .github/workflows/run-tests.yml
Makefile
30 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • do [ -d $$dir ]
  • do echo Running workflowcheck on $$dir
  • do output=$$(go fix $(GOFIX_FLAGS) ./... 2>&1)
  • done
  • else $(MAKE) GOLANGCI_LINT_BASE_REV=$$base LINT_CODE_TARGETS=$$targets lint-code
  • fetch it or override GOLANGCI_LINT_BASE_REV"
  • for dir in $(SYSTEM_WORKFLOWS_ROOT)/*/
  • go clean -testcache
  • go get go.temporal.io/testx@${sha}
  • go run ./cmd/tools/check-dependencies --base-branch $EXPR
  • go run ./cmd/tools/check-dependencies --mode plan-api-release --base-branch $GITHUB_REF_NAME
  • go run ./cmd/tools/optimize-test-sharding -shards 5 -workflow run-tests.yml -artifact-pattern junit-xml--*shard*--fun...
  • go run ./cmd/tools/parallelize $(INTEGRATION_TEST_DIRS)
  • go run ./cmd/tools/test-runner generate-summary --junit-glob=$(TEST_OUTPUT_ROOT)/junit.*.xml --summary-output-dir=$(T...
  • go run ./cmd/tools/test-runner report-crash --gotestsum=report-crash --junitfile=$(TEST_OUTPUT_ROOT)/junit.crash.xml ...
  • go run ./cmd/tools/test-runner test --gotestsum-path=$(GOTESTSUM) --max-attempts=$(MAX_TEST_ATTEMPTS) $(TEST_RUNNER_T...
  • go run ./cmd/tools/test-runner test --gotestsum-path=$(GOTESTSUM) --max-attempts=$(MAX_TEST_ATTEMPTS) $(TEST_RUNNER_T...
  • go run ./cmd/tools/test-runner test --gotestsum-path=$(GOTESTSUM) --max-attempts=$(MAX_TEST_ATTEMPTS) $(TEST_RUNNER_T...
  • go run ./cmd/tools/test-runner test --gotestsum-path=$(GOTESTSUM) --max-attempts=$(MAX_TEST_ATTEMPTS) $(TEST_RUNNER_T...
  • go run ./cmd/tools/test-runner test --gotestsum-path=$(GOTESTSUM) --max-attempts=$(MAX_TEST_ATTEMPTS) $(TEST_RUNNER_T...
  • merge-base HEAD $(GOLANGCI_LINT_BASE_REV))
  • mise exec shellcheck -- $(ACTIONLINT)
  • needs.test-setup.outputs.full_test_reason }}"
  • s
  • sort -u
  • tee -a $(CURDIR)/test.log
  • tee -a test.log
  • while [ $$n -lt $(GOFIX_MAX_ITERATIONS) ]
  • while [[ $SECONDS -lt $deadline ]]
  • while read -r dir

full scan as JSON

Review prompts

most discussed first

  • temporalio/temporal Naming Conventions Go orchestration
    raw open
  • temporalio/temporal Performance Optimization Go orchestration
    raw open
  • temporalio/temporal Testing Go orchestration
    raw open
  • raw open
  • temporalio/temporal Error Handling Go orchestration
    raw open
  • temporalio/temporal Observability Go orchestration
    raw open
  • temporalio/temporal Concurrency Go orchestration
    raw open
  • temporalio/temporal Null Handling Go orchestration
    raw open
  • temporalio/temporal Naming Conventions Other orchestration
    raw open
  • temporalio/temporal Configurations Go orchestration
    raw open
  • temporalio/temporal Temporal Go orchestration
    raw open
  • temporalio/temporal Code Style Go orchestration
    raw open
  • temporalio/temporal Algorithms Go orchestration
    raw open
  • temporalio/temporal Networking Go orchestration
    raw open
  • temporalio/temporal Logging Go orchestration
    raw open
  • temporalio/temporal Configurations Other orchestration
    raw open
  • temporalio/temporal Code Style Other orchestration
    raw open
  • temporalio/temporal Observability Yaml orchestration
    raw open
  • temporalio/temporal CI/CD Yaml orchestration
    raw open
  • temporalio/temporal API Yaml orchestration
    raw open
  • temporalio/temporal Algorithms Other orchestration
    raw open
  • temporalio/temporal API Other orchestration
    raw open
  • temporalio/temporal Security Go orchestration
    raw open