Awesome Reviewers checks + prompts

sources / vitessio/vitess

vitessio/vitess

The checks this repository runs, scanned at c2c2897, and the review prompts derived from its discussions.

6 recognised tools
26 prompts
19815 stars
Databases & Data Platforms
GitHub

Static analysis

4 tools

ToolKindCommandRuns inFound in
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/codeql_analysis.yml
zizmor CI workflow linting uses zizmorcore/zizmor-action ci .github/workflows/static_checks_etc.yml
eslint
configured, not run
Linting web/vtadmin/eslint.config.js
golangci-lint
configured, not run
Linting .golangci.yml

Testing

2 tools

ToolKindCommandRuns inFound in
ci-matrix Version and platform matrix analyze (language: 3) ci .github/workflows/codeql_analysis.yml
go-test Unit and integration tests go test $(VT_GO_PARALLEL) ./go/.../endtoend/...
go test ./go/vt/worker/
local Makefile
32 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • go generate ./go/vt/vtadmin/
  • go run -trimpath -modfile=tools/gofumpt/go.mod mvdan.cc/gofumpt -w ./go/vt/vtadmin/
  • go run -trimpath -modfile=tools/golangci-lint/go.mod github.com/golangci/golangci-lint/v2/cmd/golangci-lint run --fix...
  • go run -trimpath -modfile=tools/golangci-lint/go.mod github.com/golangci/golangci-lint/v2/cmd/golangci-lint run ./go/...
  • go run test.go -docker=false
  • go run test.go -docker=false -follow -shard $SHARD $EXTRA_FLAGS
  • go run test.go -docker=false -follow -shard tabletmanager_disk_health_monitor
  • go run test.go -docker=false -skip-build -print-log -follow -timeout=60m vtop_example
  • go run test.go -docker=false -tag=site_test
  • go run test.go -docker=false -tag=worker_test
  • go run test.go -docker=true -pull=false -flavor=$EXPR -bootstrap-version=$EXPR --follow -shard $EXPR
  • go run test.go -flavor $(flavor)
  • go run test.go -flavor $(flavor) unit
  • go run test.go -print-log -follow -pull=false -flavor=$EXPR -bootstrap-version=$EXPR local_example
  • go run test.go -print-log -follow -pull=false -flavor=$EXPR -bootstrap-version=$EXPR region_example
  • go run test.go -skip-build -docker=false -print-log -follow -tag upgrade_downgrade_backups
  • go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_onlineddl_flow
  • go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_query_serving_que...
  • go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_query_serving_que...
  • go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_query_serving_schema
  • go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_reparent
  • launchable record tests --build $GITHUB_RUN_ID go-test .
  • launchable verify
  • lint config verify
  • lint run --timeout 10m ./go/...
  • log -1 --format=%H -S"${version}" -- go/vt/servenv/version.go)
  • mvn -f java/pom.xml -B clean verify
  • unit_test }}
  • unit_test_race
  • vt tester --sharded --xunit $dir/*.test
  • vt tester --xunit --vschema $dirvschema.json $dir/*.test
  • yamllint -d {extends: relaxed, rules: {indentation: disable, line-length: disable, trailing-spaces: disable}} .github...

full scan as JSON

Review prompts

most discussed first

  • vitessio/vitess Testing Go data-systems
    raw open
  • vitessio/vitess Naming Conventions Go data-systems
    raw open
  • vitessio/vitess Concurrency Go data-systems
    raw open
  • vitessio/vitess Configurations Go data-systems
    raw open
  • vitessio/vitess Algorithms Go data-systems
    raw open
  • vitessio/vitess Code Style Go data-systems
    raw open
  • vitessio/vitess Performance Optimization Go data-systems
    raw open
  • vitessio/vitess Database Go data-systems
    raw open
  • vitessio/vitess Observability Go data-systems
    raw open
  • vitessio/vitess Null Handling Go data-systems
    raw open
  • vitessio/vitess Logging Go data-systems
    raw open
  • vitessio/vitess Configurations Other data-systems
    raw open
  • vitessio/vitess Error Handling Go data-systems
    raw open
  • vitessio/vitess Networking Go data-systems
    raw open
  • vitessio/vitess Configurations Markdown data-systems
    raw open
  • vitessio/vitess Configurations Yaml data-systems
    raw open
  • vitessio/vitess CI/CD Other data-systems
    raw open
  • vitessio/vitess Database Sql data-systems
    raw open
  • vitessio/vitess Testing Json data-systems
    raw open
  • vitessio/vitess CI/CD Yaml data-systems
    raw open
  • vitessio/vitess Observability Markdown data-systems
    raw open
  • vitessio/vitess Temporal Go data-systems
    raw open
  • vitessio/vitess Configurations Txt data-systems
    raw open
  • vitessio/vitess Database Other data-systems
    raw open
  • vitessio/vitess Database Markdown data-systems
    raw open
  • vitessio/vitess Security Yaml data-systems
    raw open