Awesome Reviewers checks + prompts

sources / discourse/discourse

discourse/discourse

The checks this repository runs, scanned at 4b18295, and the review prompts derived from its discussions.

3 recognised tools
37 prompts
44898 stars
Application Frameworks & UI
GitHub

Static analysis

2 tools

ToolKindCommandRuns inFound in
eslint Linting eslint ./frontend $(script/list_bundled_plugins) ./themes --cache --concurren...
eslint --fix ./frontend $(script/list_bundled_plugins) ./themes --no-error-on...
local package.json
eslint.config.mjs
tsc Type checking tsc -b --runExternalCode
tsc -b --runExternalCode --watch --preserveWatchOutput
ci, local .github/workflows/publish-types.yml
package.json
ToolKindCommandRuns inFound in
prettier
configured, not run
Formatting package.json
15 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • bundle exec ./sync_docs
  • bundle exec ./sync_docs --dry-run
  • bundle exec rubocop --force-exclusion {staged_files}
  • bundle exec ruby script/i18n_lint.rb {staged_files}
  • bundle exec stree check Gemfile {staged_files}
  • bundle exec yaml-lint {staged_files}
  • bundle lock --add-checksums
  • concurrently pnpm:lint:*(!fix) --names lint:
  • concurrently pnpm:lint:*:fix --names fix:
  • html-pages ./lint-progress --no-cache
  • lint-to-the-future ignore
  • lint-to-the-future output -o ./lint-progress/
  • postgres script/start_test_db.rb
  • show -s --date=format:%Y-%m-%d --format=%cd ${from_ref}^{commit})
  • show -s --date=format:%Y-%m-%d --format=%cd ${to_ref}^{commit})

full scan as JSON

Review prompts

most discussed first

  • discourse/discourse Naming Conventions Ruby app-frameworks
    raw open
  • discourse/discourse Null Handling Other app-frameworks
    raw open
  • discourse/discourse Security Ruby app-frameworks
    raw open
  • discourse/discourse Naming Conventions Other app-frameworks
    raw open
  • discourse/discourse Migrations Ruby app-frameworks
    raw open
  • discourse/discourse Code Style Ruby app-frameworks
    raw open
  • discourse/discourse Testing Ruby app-frameworks
    raw open
  • discourse/discourse Code Style Other app-frameworks
    raw open
  • discourse/discourse Code Style JavaScript app-frameworks
    raw open
  • discourse/discourse Null Handling JavaScript app-frameworks
    raw open
  • discourse/discourse API Ruby app-frameworks
    raw open
  • discourse/discourse Database Ruby app-frameworks
    raw open
  • discourse/discourse Logging Ruby app-frameworks
    raw open
  • discourse/discourse Configurations Ruby app-frameworks
    raw open
  • discourse/discourse Configurations JavaScript app-frameworks
    raw open
  • discourse/discourse API JavaScript app-frameworks
    raw open
  • discourse/discourse Configurations Other app-frameworks
    raw open
  • discourse/discourse Performance Optimization Ruby app-frameworks
    raw open
  • discourse/discourse Configurations Yaml app-frameworks
    raw open
  • discourse/discourse Code Style Css app-frameworks
    raw open
  • discourse/discourse Naming Conventions JavaScript app-frameworks
    raw open
  • discourse/discourse Performance Optimization Other app-frameworks
    raw open
  • discourse/discourse Naming Conventions Css app-frameworks
    raw open
  • discourse/discourse Error Handling Ruby app-frameworks
    raw open
  • discourse/discourse Null Handling Ruby app-frameworks
    raw open
  • discourse/discourse Algorithms Ruby app-frameworks
    raw open
  • discourse/discourse Naming Conventions Yaml app-frameworks
    raw open
  • discourse/discourse Networking JavaScript app-frameworks
    raw open
  • discourse/discourse Testing Other app-frameworks
    raw open
  • discourse/discourse Concurrency Other app-frameworks
    raw open
  • discourse/discourse Networking Other app-frameworks
    raw open
  • discourse/discourse Documentation Yaml app-frameworks
    raw open
  • discourse/discourse API Other app-frameworks
    raw open
  • discourse/discourse Error Handling Other app-frameworks
    raw open
  • discourse/discourse Concurrency JavaScript app-frameworks
    raw open
  • discourse/discourse Security JavaScript app-frameworks
    raw open
  • discourse/discourse Security Markdown app-frameworks
    raw open