Awesome Reviewers checks + prompts

sources / duckdb/duckdb

duckdb/duckdb

The checks this repository runs, scanned at 325a2a3, and the review prompts derived from its discussions.

4 recognised tools
34 prompts
32061 stars
Databases & Data Platforms
GitHub
ToolKindCommandRuns inFound in
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/NightlyTests.yml

Testing

2 tools

ToolKindCommandRuns inFound in
ci-matrix Version and platform matrix codeql-analyze (language: 3) ci .github/workflows/NightlyTests.yml
pytest Unit and integration tests pytest tools/shell/tests --shell-binary build/release/duckdb
pytest tools/sqllogic/tests --unittest-binary build/release/test/unittest
pytest tools/shell/tests --shell-binary duckdb.exe
ci .github/workflows/Main.yml
.github/workflows/OSX.yml
.github/workflows/Windows.yml
ToolKindCommandRuns inFound in
black
configured, not run
Formatting api_spec/pyproject.toml
74 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • autocomplete
  • bash scripts/ci/linux_release_link_checks.sh
  • cmake $(GENERATOR) $(FORCE_COLOR) ${STATIC_LIBCPP} ${CMAKE_VARS} -DCLANG_TIDY=1 -DDISABLE_UNITY=1 -DBUILD_EXTENSIONS=...
  • cmake $(GENERATOR) $(FORCE_COLOR) ${WARNINGS_AS_ERRORS} ${FORCE_32_BIT_FLAG} ${DISABLE_UNITY_FLAG} ${DISABLE_SANITIZE...
  • cmake -DCLANG_TIDY=1 -DDISABLE_UNITY=1 -DBUILD_EXTENSIONS=parquet -DBUILD_SHELL=0 ../..
  • cmake -DCMAKE_BUILD_TYPE=Debug ${CMAKE_VARS} -B .cache/clangd/debug .
  • cmake -DCONFIG_DIR=.github/config -DPATCH_DIR=.github/patches/extensions -P scripts/check_extension_patches.cmake
  • cmake -P scripts/ci/test_architecture_flags.cmake
  • do command -v $$cmd >/dev/null 2>&1
  • do dpkg-query -W -f=$${Status} $$pkg 2>/dev/null
  • done
  • doxygen Doxyfile
  • else rm -f extension_entries.hpp.diff
  • for cmd in $(1)
  • for pkg in $(1)
  • github.event.inputs.skip_tests
  • httpfs
  • icu
  • inet
  • json
  • lipo build/release_amd64/libs/$library_name -verify_arch x86_64
  • lipo build/release_amd64/src/$library_name -verify_arch x86_64
  • lipo build/release_arm64/libs/$library_name -verify_arch arm64
  • lipo build/release_arm64/src/$library_name -verify_arch arm64
  • open build/docs/html/index.html
  • parquet
  • python -u ../../scripts/run-clangd-tidy.py -j $(CI_TIDY_JOBS) ${CLANGD_TIDY_BINARY_PARAMETER} ${CLANGD_BINARY_PARAMET...
  • python -u scripts/test_benchmark_sql_runner.py --shell build/relassert/duckdb
  • python ../../scripts/run-clang-tidy.py -quiet -j $(CI_CPU_COUNT) ${TIDY_BINARY_PARAMETER} ${TIDY_SHARD_PARAMETERS} ${...
  • python build/release/test/run.py
  • python scripts/banned_symbols_check.py --directory build/release/src
  • python scripts/ci/check_staged_extensions.py --duckdb-commit $EXPR --duckdb-version $EXPR --extensions httpfs,json,pa...
  • python scripts/ci/run_unit_tests.py --jobs $(CI_CPU_COUNT) $(T)
  • python scripts/clang-tidy-diff.py -path build/tidy -quiet -j $(CI_CPU_COUNT) ${TIDY_BINARY_PARAMETER} ${TIDY_PERFORM_...
  • python scripts/exported_symbols_check.py build/release/src/libduckdb*.so
  • python scripts/format.py --all --check $(T)
  • python scripts/format.py --all --check --silent $(T)
  • python scripts/format.py --all --fix --noconfirm $(T)
  • python scripts/format.py --files-from $(FORMAT_FILES_FROM) --check --silent $(T)
  • python scripts/format.py --files-from $(FORMAT_FILES_FROM) --fix --noconfirm $(T)

full scan as JSON

Review prompts

most discussed first

  • duckdb/duckdb Naming Conventions Other data-systems
    raw open
  • duckdb/duckdb Naming Conventions C++ data-systems
    raw open
  • duckdb/duckdb Code Style C++ data-systems
    raw open
  • duckdb/duckdb Performance Optimization C++ data-systems
    raw open
  • duckdb/duckdb Testing Other data-systems
    raw open
  • duckdb/duckdb Code Style Other data-systems
    raw open
  • duckdb/duckdb CI/CD Yaml data-systems
    raw open
  • duckdb/duckdb Null Handling Other data-systems
    raw open
  • duckdb/duckdb Database C++ data-systems
    raw open
  • duckdb/duckdb Algorithms Other data-systems
    raw open
  • duckdb/duckdb Null Handling C++ data-systems
    raw open
  • duckdb/duckdb Error Handling C++ data-systems
    raw open
  • duckdb/duckdb Configurations Other data-systems
    raw open
  • duckdb/duckdb API Other data-systems
    raw open
  • duckdb/duckdb Concurrency C++ data-systems
    raw open
  • duckdb/duckdb Database Other data-systems
    raw open
  • duckdb/duckdb Configurations C++ data-systems
    raw open
  • duckdb/duckdb Migrations Other data-systems
    raw open
  • duckdb/duckdb Performance Optimization Other data-systems
    raw open
  • duckdb/duckdb Logging C++ data-systems
    raw open
  • duckdb/duckdb Configurations Python data-systems
    raw open
  • duckdb/duckdb Naming Conventions Json data-systems
    raw open
  • duckdb/duckdb Configurations Txt data-systems
    raw open
  • duckdb/duckdb Testing Csv data-systems
    raw open
  • duckdb/duckdb Migrations C++ data-systems
    raw open
  • duckdb/duckdb Algorithms C++ data-systems
    raw open
  • duckdb/duckdb API Json data-systems
    raw open
  • duckdb/duckdb Security Other data-systems
    raw open
  • duckdb/duckdb Security C++ data-systems
    raw open
  • duckdb/duckdb Performance Optimization Python data-systems
    raw open
  • duckdb/duckdb API Python data-systems
    raw open
  • duckdb/duckdb Code Style Python data-systems
    raw open
  • duckdb/duckdb Configurations Yaml data-systems
    raw open
  • duckdb/duckdb Testing Python data-systems
    raw open