Awesome Reviewers checks + prompts

sources / electron/electron

electron/electron

The checks this repository runs, scanned at 6752821, and the review prompts derived from its discussions.

5 recognised tools
29 prompts
117644 stars
Developer Tooling
GitHub

Static analysis

2 tools

ToolKindCommandRuns inFound in
tsc Type checking tsc local package.json
eslint
configured, not run
Linting docs/fiddles/.eslintrc.json

Testing

3 tools

ToolKindCommandRuns inFound in
go-test Unit and integration tests go test ./execute/spawnhelper/ ./execute/localexec/ ci .github/workflows/pipeline-segment-build-siso.yml
node-test Unit and integration tests node --test script/benchmarks/test/*.test.mts ci .github/workflows/pipeline-segment-benchmarks.yml
vitest
configured, not run
Unit and integration tests spec/package.json
spec/vitest.config.ts
48 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • Add-Type -Namespace ElectronCI -Name User32 -MemberDefinition @'
  • Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it remove...
  • electron-typescript-definitions --api=electron-api.json
  • for build_type in testing release
  • for test_file in $tests_files
  • lint-roller-markdown-api-history --root ./docs/api/ --schema ./docs/api-history.schema.json --breaking-changes-file ....
  • lint-roller-markdown-links --resource-root . --root docs **/*.md
  • lint-roller-markdown-oxfmt --root docs **/*.md --config docs/.oxfmtrc.json
  • lint-roller-markdown-oxlint --root docs **/*.md
  • lint-roller-markdown-ts-check --root docs **/*.md --ignore breaking-changes.md
  • lint-staged
  • local gn_version clang_format_objects
  • node ./script/gn-check.js
  • node ./script/lint-roller-chromium-changes.mjs
  • node ./script/lint.js
  • node ./script/lint.js --cc
  • node ./script/lint.js --gn
  • node ./script/lint.js --gn --fix
  • node ./script/lint.js --js
  • node ./script/lint.js --md
  • node ./script/lint.js --objc
  • node ./script/lint.js --py
  • node ./script/run-clang-tidy.mts
  • node ./script/spec-runner.js
  • node build/bundle/typecheck.mjs
  • node electron/script/nan-spec-runner.js
  • node electron/script/node-spec-runner.js --default --jUnitDir=junit
  • node script/copy-pipeline-segment-publish.js --check
  • node script/cp.mjs electron.d.ts
  • node script/gen-filenames.mts --check
  • node script/gen-hunspell-filenames.js --check
  • node script/gen-libc++-filenames.js --check
  • node script/gen-siso-revision.js --check
  • node script/yarn.js create-typescript-definitions
  • node script/yarn.js lint
  • node script/yarn.js test --runners=main --trace-uncaught $LOGGING_ARGS --files $tests_files
  • node script/yarn.js typecheck --project tsconfig.electron.json
  • node spec/ts-smoke/runner.js
  • oxfmt --check {lib,spec,script,build,default_app,npm,typings}/**/*.{js,ts,mjs,mts,cjs}
  • oxfmt --write {lib,spec,script,build,default_app,npm,typings}/**/*.{js,ts,mjs,mts,cjs}

full scan as JSON

Review prompts

most discussed first

  • electron/electron API Other devtools
    raw open
  • electron/electron API Markdown devtools
    raw open
  • electron/electron Documentation Markdown devtools
    raw open
  • electron/electron Algorithms Other devtools
    raw open
  • electron/electron Configurations Other devtools
    raw open
  • electron/electron Null Handling Other devtools
    raw open
  • electron/electron Code Style Other devtools
    raw open
  • electron/electron Performance Optimization Other devtools
    raw open
  • electron/electron Testing TypeScript devtools
    raw open
  • electron/electron Naming Conventions Other devtools
    raw open
  • electron/electron Error Handling Other devtools
    raw open
  • electron/electron Null Handling Markdown devtools
    raw open
  • electron/electron Configurations Markdown devtools
    raw open
  • electron/electron Error Handling TypeScript devtools
    raw open
  • electron/electron Security Markdown devtools
    raw open
  • electron/electron Naming Conventions Markdown devtools
    raw open
  • electron/electron Null Handling TypeScript devtools
    raw open
  • electron/electron Concurrency Other devtools
    raw open
  • electron/electron Error Handling Markdown devtools
    raw open
  • electron/electron Security Other devtools
    raw open
  • electron/electron Code Style TypeScript devtools
    raw open
  • electron/electron Configurations TypeScript devtools
    raw open
  • electron/electron Security Shell devtools
    raw open
  • electron/electron Configurations Yaml devtools
    raw open
  • electron/electron Networking Other devtools
    raw open
  • electron/electron CI/CD Yaml devtools
    raw open
  • electron/electron Naming Conventions Yaml devtools
    raw open
  • electron/electron Security JavaScript devtools
    raw open
  • electron/electron Security TypeScript devtools
    raw open