Awesome Reviewers checks + prompts

sources / Homebrew/brew

Homebrew/brew

The checks this repository runs, scanned at b090520, and the review prompts derived from its discussions.

3 recognised tools
27 prompts
44168 stars
Developer Tooling
GitHub

Static analysis

3 tools

ToolKindCommandRuns inFound in
actionlint CI workflow linting actionlint ci .github/workflows/actionlint.yml
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/codeql-analysis.yml
zizmor CI workflow linting zizmor --format sarif . > results.sarif ci .github/workflows/actionlint.yml
22 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • base64 --decode >${RUNNER_TEMP:?}/check_template.rb
  • base64 --decode >${RUNNER_TEMP}/check-issues/templates/${repo//\//-}-${template_path##*/}
  • bash .github/scripts/check-licenses.sh
  • brewtest /opt/homebrew/bin/hello --version
  • brewtest /usr/bin/env HOMEBREW_NO_SUDO=1 /opt/homebrew/bin/brew install --force-bottle hello
  • done <${RUNNER_TEMP:?}/check-issues/incomplete-template-comment-ids
  • done <${RUNNER_TEMP:?}/check-prs/incomplete-template-comment-ids
  • done <${RUNNER_TEMP:?}/check-prs/missing-description-comment-ids
  • read -ra test_flags <<< $TEST_FLAGS
  • ruby ${RUNNER_TEMP:?}/check_template.rb issue ${RUNNER_TEMP}/check-issues/body ${RUNNER_TEMP}/check-issues/templates ...
  • ruby ${RUNNER_TEMP:?}/check_template.rb pull-request ${RUNNER_TEMP}/check-prs/body ${RUNNER_TEMP}/check-prs/template ...
  • ruby ${RUNNER_TEMP}/check_template.rb pull-request-description ${RUNNER_TEMP}/check-prs/body ${RUNNER_TEMP}/check-prs...
  • security create-keychain -p ${TEMPORARY_KEYCHAIN_PASSWORD} ${TEMPORARY_KEYCHAIN_PATH}
  • security delete-keychain ${RUNNER_TEMP}/${TEMPORARY_KEYCHAIN_FILE}
  • security import ${RUNNER_TEMP}/${TEMPORARY_CERTIFICATE_FILE} -k ${RUNNER_TEMP}/${TEMPORARY_KEYCHAIN_FILE} -P ${PKG_AP...
  • security list-keychain -d user -s ${RUNNER_TEMP}/${TEMPORARY_KEYCHAIN_FILE}
  • security set-keychain-settings -l -u -t 21600 ${TEMPORARY_KEYCHAIN_PATH}
  • security unlock-keychain -p ${TEMPORARY_KEYCHAIN_PASSWORD} ${TEMPORARY_KEYCHAIN_PATH}
  • sysadminctl -addUser brewtest -password $(uuidgen) -shell /bin/bash
  • typeset -A push_hash
  • typeset -A tag_hash
  • vale docs/

full scan as JSON

Review prompts

most discussed first

  • Homebrew/brew Configurations Markdown devtools
    raw open
  • Homebrew/brew Null Handling Ruby devtools
    raw open
  • Homebrew/brew Algorithms Ruby devtools
    raw open
  • Homebrew/brew API Ruby devtools
    raw open
  • Homebrew/brew Naming Conventions Ruby devtools
    raw open
  • Homebrew/brew Documentation Markdown devtools
    raw open
  • Homebrew/brew Error Handling Ruby devtools
    raw open
  • Homebrew/brew Performance Optimization Ruby devtools
    raw open
  • Homebrew/brew CI/CD Yaml devtools
    raw open
  • Homebrew/brew Code Style Ruby devtools
    raw open
  • Homebrew/brew Configurations Ruby devtools
    raw open
  • Homebrew/brew Naming Conventions Shell devtools
    raw open
  • Homebrew/brew CI/CD Ruby devtools
    raw open
  • Homebrew/brew Testing Ruby devtools
    raw open
  • Homebrew/brew Security Ruby devtools
    raw open
  • Homebrew/brew Documentation Ruby devtools
    raw open
  • Homebrew/brew Networking Ruby devtools
    raw open
  • Homebrew/brew Configurations Shell devtools
    raw open
  • Homebrew/brew Error Handling Shell devtools
    raw open
  • Homebrew/brew API Shell devtools
    raw open
  • Homebrew/brew CI/CD Markdown devtools
    raw open
  • Homebrew/brew Naming Conventions Markdown devtools
    raw open
  • Homebrew/brew Security Yaml devtools
    raw open
  • Homebrew/brew Configurations Other devtools
    raw open
  • Homebrew/brew Configurations Yaml devtools
    raw open
  • Homebrew/brew CI/CD Shell devtools
    raw open
  • Homebrew/brew Security Markdown devtools
    raw open