Awesome Reviewers checks + prompts

sources / neondatabase/neon

neondatabase/neon

The checks this repository runs, scanned at fa50421, and the review prompts derived from its discussions.

8 recognised tools
50 prompts
19015 stars
Databases & Data Platforms
GitHub
ToolKindCommandRuns inFound in
tla-plus
configured, not run
Proofs and specifications safekeeper/spec/MCProposerAcceptorReconfig.tla

Static analysis

3 tools

ToolKindCommandRuns inFound in
mypy Type checking mypy . ci .github/workflows/_check-codestyle-python.yml
pyproject.toml
ruff-check Linting ruff check . ci .github/workflows/_check-codestyle-python.yml
pyproject.toml
clippy
configured, not run
Linting clippy.toml

Testing

1 tool

ToolKindCommandRuns inFound in
pytest
configured, not run
Unit and integration tests pytest.ini
ToolKindCommandRuns inFound in
ruff-format Formatting ruff format --check . ci .github/workflows/_check-codestyle-python.yml
rustfmt Formatting cargo fmt --all -- --check ci .github/workflows/_check-codestyle-rust.yml
compute_tools/rustfmt.toml

Supply chain

1 tool

ToolKindCommandRuns inFound in
cargo-deny Dependency audit cargo deny check --hide-inclusion-graph $CARGO_DENY_TARGET ci .github/workflows/cargo-deny.yml
deny.toml
15 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • elif [[ $BUILD_TYPE == debug ]]
  • elif [[ $BUILD_TYPE == release ]]
  • for build_type in debug release
  • jsonnetfmt --in-place $(jsonnet_files)
  • jsonnetfmt --test $(jsonnet_files)
  • neonvm-azure-captest-new
  • neonvm-captest-freetier
  • neonvm-captest-new
  • neonvm-captest-new-many-tables
  • neonvm-captest-reuse
  • python upload_results_to_perf_test_results.py --load-log $LOAD_LOG --run-type load --warehouses ${WAREHOUSES} --min-c...
  • python upload_results_to_perf_test_results.py --summary-json $OPTRATE_JSON --results-csv $OPTRATE_CSV --run-type opt-...
  • python upload_results_to_perf_test_results.py --summary-json $RAMPUP_JSON --results-csv $RAMPUP_CSV --run-type ramp-u...
  • python upload_results_to_perf_test_results.py --summary-json $WARMUP_JSON --results-csv $WARMUP_CSV --run-type warmup...
  • uniq > postgres-$*-typedefs-full.list

full scan as JSON

Review prompts

most discussed first

  • neondatabase/neon Error Handling Rust data-systems
    raw open
  • neondatabase/neon Naming Conventions Rust data-systems
    raw open
  • neondatabase/neon API Rust data-systems
    raw open
  • neondatabase/neon Performance Optimization Rust data-systems
    raw open
  • neondatabase/neon Code Style Rust data-systems
    raw open
  • neondatabase/neon Logging Rust data-systems
    raw open
  • neondatabase/neon Configurations Toml data-systems
    raw open
  • neondatabase/neon Observability Rust data-systems
    raw open
  • neondatabase/neon Naming Conventions Python data-systems
    raw open
  • neondatabase/neon Naming Conventions Other data-systems
    raw open
  • neondatabase/neon Configurations Other data-systems
    raw open
  • neondatabase/neon Documentation Rust data-systems
    raw open
  • neondatabase/neon Concurrency Rust data-systems
    raw open
  • neondatabase/neon Configurations Rust data-systems
    raw open
  • neondatabase/neon Networking Rust data-systems
    raw open
  • neondatabase/neon Algorithms Rust data-systems
    raw open
  • neondatabase/neon CI/CD Yaml data-systems
    raw open
  • neondatabase/neon Performance Optimization Markdown data-systems
    raw open
  • neondatabase/neon Null Handling Rust data-systems
    raw open
  • neondatabase/neon Security Markdown data-systems
    raw open
  • neondatabase/neon Error Handling C data-systems
    raw open
  • neondatabase/neon API Markdown data-systems
    raw open
  • neondatabase/neon Configurations Python data-systems
    raw open
  • neondatabase/neon Testing Python data-systems
    raw open
  • neondatabase/neon Algorithms C data-systems
    raw open
  • neondatabase/neon Caching Markdown data-systems
    raw open
  • neondatabase/neon Database Rust data-systems
    raw open
  • neondatabase/neon Security Rust data-systems
    raw open
  • neondatabase/neon Concurrency C data-systems
    raw open
  • neondatabase/neon Code Style C data-systems
    raw open
  • neondatabase/neon Configurations C data-systems
    raw open
  • neondatabase/neon Caching Rust data-systems
    raw open
  • neondatabase/neon Performance Optimization Python data-systems
    raw open
  • neondatabase/neon Database Markdown data-systems
    raw open
  • neondatabase/neon Algorithms Markdown data-systems
    raw open
  • neondatabase/neon Networking C data-systems
    raw open
  • neondatabase/neon Configurations Markdown data-systems
    raw open
  • neondatabase/neon Observability Other data-systems
    raw open
  • neondatabase/neon Performance Optimization C data-systems
    raw open
  • neondatabase/neon Documentation Python data-systems
    raw open
  • neondatabase/neon Concurrency Python data-systems
    raw open
  • neondatabase/neon Database Other data-systems
    raw open
  • neondatabase/neon Database Python data-systems
    raw open
  • neondatabase/neon Code Style Yaml data-systems
    raw open
  • neondatabase/neon API Other data-systems
    raw open
  • neondatabase/neon Networking Markdown data-systems
    raw open
  • neondatabase/neon Concurrency Other data-systems
    raw open
  • neondatabase/neon Security Sql data-systems
    raw open
  • neondatabase/neon Security Yaml data-systems
    raw open
  • neondatabase/neon Security Dockerfile data-systems
    raw open