Awesome Reviewers checks + prompts

sources / argoproj/argo-cd

argoproj/argo-cd

The checks this repository runs, scanned at 211c2b4, and the review prompts derived from its discussions.

11 recognised tools
38 prompts
20149 stars
Containers & Orchestration
GitHub

Static analysis

8 tools

ToolKindCommandRuns inFound in
actionlint CI workflow linting actionlint --version
actionlint
ci, local .github/workflows/ci-build.yaml
Makefile
codeql Security scanning uses github/codeql-action/analyze ci .github/workflows/codeql.yml
eslint Linting eslint
eslint --fix
local Makefile
ui/package.json
ui/eslint.config.mjs
golangci-lint Linting uses golangci/golangci-lint-action
golangci-lint --version
golangci-lint run --fix --verbose
ci, local .github/workflows/ci-build.yaml
Makefile
gitops-engine/Makefile
.golangci.yaml
mkdocs Docs build mkdocs build local Makefile
shellcheck Linting shellcheck -e SC2059 -e SC2154 -e SC2034 -e SC2016 -e SC1091 $(find . -type f... ci .github/workflows/ci-build.yaml
tsc Type checking tsc --noEmit --project ./src/app local Makefile
ui/package.json
zizmor CI workflow linting uses zizmorcore/zizmor-action ci .github/workflows/zizmor.yaml

Testing

2 tools

ToolKindCommandRuns inFound in
go-test Unit and integration tests go test ./hack/gen-catalog
go test -race -cover ./... -args -test.gocoverdir=$(PWD)/test-results/gitops-...
go test -race ./... -coverprofile=coverage.out
local Makefile
gitops-engine/Makefile
jest Unit and integration tests jest local ui/package.json
ui/jest.config.js
ToolKindCommandRuns inFound in
prettier
configured, not run
Formatting ui/package.json
ui/.prettierrc
23 other commands the scanner could not classify

Commands from CI steps and task runners that look like checks but match no known tool. Some are checks, some are not.

  • e2e-code-coverage -mindepth 2 -maxdepth 2 -type d ( -name applicationset-controller -o -name repo-server -o -name app...
  • else DIST_DIR=${DIST_DIR} RERUN_FAILS=0 PACKAGES=$(TEST_MODULE) ./hack/test.sh -args -test.gocoverdir=$(PWD)/test-res...
  • else DIST_DIR=${DIST_DIR} RERUN_FAILS=0 PACKAGES=$(TEST_MODULE) ./hack/test.sh -race -args -test.gocoverdir=$(PWD)/te...
  • go run ./hack/e2e-shard-weights-refresh -shards ${SHARDS} -report ${RUNNER_TEMP}/report.md -repo ${GITHUB_REPOSITORY}...
  • go run ./hack/gen-catalog docs
  • go run ./hack/gen-docs
  • go run ./hack/k8s
  • go run tools/cmd-docs/main.go
  • goreman -f $(ARGOCD_PROCFILE) start ${ARGOCD_START}
  • kubectl apply --server-side --force-conflicts -f -
  • kubectl apply -f https://raw.githubusercontent.com/open-cluster-management/api/a6845f2ebcb186ec26b832f60c988537a58f38...
  • kubectl config set-context --current --namespace=argocd-e2e
  • kubectl create ns argocd-e2e
  • kubectl create ns argocd-e2e-external
  • kubectl create ns argocd-e2e-external-2
  • kubectl get secret argocd-redis -o jsonpath={.data.auth}
  • kubectl wait --for=condition=Established --timeout=60s crd/applications.argoproj.io crd/applicationsets.argoproj.io c...
  • log -1 --pretty=format:%B
  • mkdocs serve
  • see the e2e-server log artifact"
  • select (.type==Checksum)
  • sha256sum ./dist/$(BIN_NAME)-*
  • true

full scan as JSON

Review prompts

most discussed first

  • argoproj/argo-cd Error Handling Go orchestration
    raw open
  • argoproj/argo-cd Configurations Markdown orchestration
    raw open
  • argoproj/argo-cd Code Style Go orchestration
    raw open
  • argoproj/argo-cd Configurations Go orchestration
    raw open
  • argoproj/argo-cd Null Handling Go orchestration
    raw open
  • argoproj/argo-cd Naming Conventions TSX orchestration
    raw open
  • argoproj/argo-cd Logging Go orchestration
    raw open
  • argoproj/argo-cd Documentation Markdown orchestration
    raw open
  • argoproj/argo-cd Concurrency Go orchestration
    raw open
  • argoproj/argo-cd Naming Conventions Go orchestration
    raw open
  • argoproj/argo-cd Code Style TSX orchestration
    raw open
  • argoproj/argo-cd Algorithms Go orchestration
    raw open
  • argoproj/argo-cd API Go orchestration
    raw open
  • argoproj/argo-cd Security Markdown orchestration
    raw open
  • argoproj/argo-cd Security Go orchestration
    raw open
  • argoproj/argo-cd Networking Markdown orchestration
    raw open
  • argoproj/argo-cd Testing Go orchestration
    raw open
  • argoproj/argo-cd Documentation Go orchestration
    raw open
  • argoproj/argo-cd API Markdown orchestration
    raw open
  • argoproj/argo-cd Configurations Other orchestration
    raw open
  • argoproj/argo-cd React TSX orchestration
    raw open
  • argoproj/argo-cd Observability Markdown orchestration
    raw open
  • argoproj/argo-cd Code Style Markdown orchestration
    raw open
  • argoproj/argo-cd Configurations Yaml orchestration
    raw open
  • argoproj/argo-cd Naming Conventions Markdown orchestration
    raw open
  • argoproj/argo-cd Code Style Css orchestration
    raw open
  • argoproj/argo-cd CI/CD Markdown orchestration
    raw open
  • argoproj/argo-cd Configurations TSX orchestration
    raw open
  • argoproj/argo-cd Naming Conventions Other orchestration
    raw open
  • argoproj/argo-cd Error Handling TSX orchestration
    raw open
  • argoproj/argo-cd API TypeScript orchestration
    raw open
  • argoproj/argo-cd API TSX orchestration
    raw open
  • argoproj/argo-cd Code Style Other orchestration
    raw open
  • argoproj/argo-cd Observability Other orchestration
    raw open
  • argoproj/argo-cd Null Handling TSX orchestration
    raw open
  • argoproj/argo-cd Configurations Shell orchestration
    raw open
  • argoproj/argo-cd Security TSX orchestration
    raw open
  • argoproj/argo-cd Security Yaml orchestration
    raw open